Move or remove will_be_retried from TestStepResult

[aslakhellesoy]

See 4baf62d#r37297905 for context.

Results are only attached to steps, which is why the message was renamed.

I’m not sure where the will_be_retried property is written or read, I think somewhere in Cucumber.js @charlierudolph @davidjgoss?

Would it make more sense to place it on TestCaseFinished?

[davidjgoss]

Agree that will_be_retried makes sense on TestCaseFinished given it represents a finished attempt. I defer to Charlie though.

Cucumber.js currently uses TestResult as both a step result and test case attempt result, in pickle_runner.ts - in the version of messages we are currently on, TestCaseFinished still has a result, on which we set the overall duration and status for the attempt. From the commit where it was removed, is the idea now to use cucumber-query to resolve that kind of aggregated data rather than emit it on the messages?

[charlierudolph]

I'm fine moving it from part of TestResult to TestCaseFinished. And yes definitely interested how we should be getting a test case attempt's results when we don't have a result field on there anymore

[aslakhellesoy]

@davidjgoss yes, I think @cucumber/query should be used for this. It currently doesn't track TestCaseStarted#id / TestStepFinished#testCaseStartedId, but it would be trivial to make it do so.

@charlierudolph I'm thinking we could add a testCaseStartedId parameter to #getPickleStepTestStepResults and #getPickleTestStepResults. Then the returned array can be passed through #getWorstTestStepResult to get a single result.

WDYT?

[charlierudolph]

Sounds good to me.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[stale]

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[stale]

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.