From 028f0176666b5ff11a813220916a682c74e4d998 Mon Sep 17 00:00:00 2001 From: mpkorstanje Date: Mon, 14 Dec 2020 21:24:13 +0100 Subject: [PATCH] [Build] Update versions --- CHANGELOG.md | 2 +- .../main/java/io/cucumber/core/options/PluginOption.java | 6 ++++-- .../java/io/cucumber/core/options/PluginOptionTest.java | 3 +-- examples/java-calculator-junit5/pom.xml | 2 +- examples/java-calculator/pom.xml | 2 +- examples/spring-txn/pom.xml | 2 +- 6 files changed, 9 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ead1b2358c..63181394d2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] (In Git) ### Added - * [JUnit Platform] Warn if feature files could not be found ([#2179](https://github.com/cucumber/cucumber-jvm/issues/2179) M.P. Korstanje) ### Changed @@ -17,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Removed ### Fixed + * [JUnit Platform] Warn if feature files could not be found ([#2179](https://github.com/cucumber/cucumber-jvm/issues/2179) M.P. Korstanje) * [Core] SummaryPrinter outputs clickable links ([#2184](https://github.com/cucumber/cucumber-jvm/issues/2184) M.P. Korstanje) * [Core] Merge duplicate plugin options ([#2190](https://github.com/cucumber/cucumber-jvm/issues/2190) M.P. Korstanje) diff --git a/core/src/main/java/io/cucumber/core/options/PluginOption.java b/core/src/main/java/io/cucumber/core/options/PluginOption.java index 4eacbd654d..16926c9697 100644 --- a/core/src/main/java/io/cucumber/core/options/PluginOption.java +++ b/core/src/main/java/io/cucumber/core/options/PluginOption.java @@ -209,8 +209,10 @@ boolean isSummaryPrinter() { @Override public boolean equals(Object o) { - if (this == o) return true; - if (o == null || getClass() != o.getClass()) return false; + if (this == o) + return true; + if (o == null || getClass() != o.getClass()) + return false; PluginOption that = (PluginOption) o; return pluginClass.equals(that.pluginClass) && Objects.equals(argument, that.argument); } diff --git a/core/src/test/java/io/cucumber/core/options/PluginOptionTest.java b/core/src/test/java/io/cucumber/core/options/PluginOptionTest.java index cbeef59347..0e4fae592f 100644 --- a/core/src/test/java/io/cucumber/core/options/PluginOptionTest.java +++ b/core/src/test/java/io/cucumber/core/options/PluginOptionTest.java @@ -96,9 +96,8 @@ void throws_for_unknown_plugins() { "PLUGIN can also be a fully qualified class name, allowing registration of 3rd party plugins. The 3rd party plugin must implement io.cucumber.plugin.Plugin")); } - @Test - void should_implement_equals_and_hashcode(){ + void should_implement_equals_and_hashcode() { PluginOption prettyPluginA = PluginOption.forClass(PrettyFormatter.class); PluginOption prettyPluginB = PluginOption.forClass(PrettyFormatter.class); PluginOption htmlPluginA = PluginOption.forClass(HtmlFormatter.class, "out.html"); diff --git a/examples/java-calculator-junit5/pom.xml b/examples/java-calculator-junit5/pom.xml index c844c26809..7bb1c0ac3f 100644 --- a/examples/java-calculator-junit5/pom.xml +++ b/examples/java-calculator-junit5/pom.xml @@ -13,7 +13,7 @@ io.cucumber.examples.junit5 - 2.11.3 + 2.12.0 diff --git a/examples/java-calculator/pom.xml b/examples/java-calculator/pom.xml index 3d119e9e40..e012c20459 100644 --- a/examples/java-calculator/pom.xml +++ b/examples/java-calculator/pom.xml @@ -13,7 +13,7 @@ io.cucumber.examples.java - 2.11.3 + 2.12.0 diff --git a/examples/spring-txn/pom.xml b/examples/spring-txn/pom.xml index 84c23943b6..adab5b92c4 100644 --- a/examples/spring-txn/pom.xml +++ b/examples/spring-txn/pom.xml @@ -13,7 +13,7 @@ io.cucumber.examples.spring.txn - 2.3.5.RELEASE + 2.4.1