Revert "[Core] Remove the deprecated -f/--format option. (#1260)" (#1294)

Author: Haroon Sheikh

core/src/main/java/cucumber/api/CucumberOptions.java

@@ -36,6 +36,13 @@
      */
     String[] tags() default {};
 
+    /**
+     * @return what formatter(s) to use
+     * @deprecated use {@link #plugin()}
+     */
+    @Deprecated
+    String[] format() default {};
+
     /**
      * @return what plugins(s) to use
      */

core/src/main/java/cucumber/runtime/RuntimeOptions.java

@@ -155,6 +155,9 @@ private void parse(List<String> args) {
                 parsedTagFilters.add(args.remove(0));
             } else if (arg.equals("--plugin") || arg.equals("--add-plugin") || arg.equals("-p")) {
                 parsedPluginData.addPluginName(args.remove(0), arg.equals("--add-plugin"));
+            } else if (arg.equals("--format") || arg.equals("-f")) {
+                System.err.println("WARNING: Cucumber-JVM's --format option is deprecated. Please use --plugin instead.");
+                parsedPluginData.addPluginName(args.remove(0), true);
             } else if (arg.equals("--no-dry-run") || arg.equals("--dry-run") || arg.equals("-d")) {
                 dryRun = !arg.startsWith("--no-");
             } else if (arg.equals("--no-strict") || arg.equals("--strict") || arg.equals("-s")) {

core/src/main/java/cucumber/runtime/RuntimeOptionsFactory.java

@@ -87,6 +87,7 @@ private void addTags(CucumberOptions options, List<String> args) {
     private void addPlugins(CucumberOptions options, List<String> args) {
         List<String> plugins = new ArrayList<String>();
         plugins.addAll(asList(options.plugin()));
+        plugins.addAll(asList(options.format()));
         for (String plugin : plugins) {
             args.add("--plugin");
             args.add(plugin);

core/src/main/resources/cucumber/api/cli/USAGE.txt

@@ -14,6 +14,7 @@ Options:
                                          registration of 3rd party plugins.
                                          --add-plugin does not clobber plugins of that 
                                          type defined from a different source.
+  -f, --format FORMAT[:PATH_OR_URL]      Deprecated. Use --plugin instead.
   -t, --tags TAG_EXPRESSION              Only run scenarios tagged with tags matching
                                          TAG_EXPRESSION.
   -n, --name REGEXP                      Only run scenarios whose names match REGEXP.

examples/java-calculator-testng/src/test/java/cucumber/examples/java/calculator/RunCukesByCompositionTest.java

@@ -14,7 +14,7 @@
  * AbstractTestNGCucumberTests but still executes each scenario as a separate
  * TestNG test.
  */
-@CucumberOptions(strict = true, plugin = "json:target/cucumber-report-feature-composite.json")
+@CucumberOptions(strict = true, format = "json:target/cucumber-report-feature-composite.json")
 public class RunCukesByCompositionTest extends RunCukesByCompositionBase {
     private TestNGCucumberRunner testNGCucumberRunner;