Ignore duplicate features instead of throwing exception. Closes #259.

Author: aslakhellesoy

History.md

@@ -1,5 +1,6 @@
 ## [Git master](https://github.com/cucumber/cucumber-jvm/compare/v1.0.0.RC20...master)
 
+* [Core] Ignore duplicate features instead of throwing exception. ([#259](https://github.com/cucumber/cucumber-jvm/issues/259) Aslak Hellesøy)
 * [Core] Wrong message when runner on a non existing tag on feature ([#245](https://github.com/cucumber/cucumber-jvm/issues/245) Aslak Hellesøy, Jérémy Goupil)
 * [Groovy, Groovy, JRuby, Rhino] Make sure UTF-8 encoding is used everywhere ([#251](https://github.com/cucumber/cucumber-jvm/issues/251) Aslak Hellesøy)
 * [Core, Cloure] Fixed StepDefinitionMatch to work with StepDefinitions that return null for getParameterTypes ([#250](https://github.com/cucumber/cucumber-jvm/issues/250), [#255](https://github.com/cucumber/cucumber-jvm/pull/255) Nils Wloka)

core/src/main/java/cucumber/runtime/FeatureBuilder.java

@@ -94,20 +94,21 @@ public void close() {
     }
 
     public void parse(Resource resource, List<Object> filters) {
-        Formatter formatter = this;
-        if (!filters.isEmpty()) {
-            formatter = new FilterFormatter(this, filters);
-        }
-        Parser parser = new Parser(formatter);
         String gherkin = read(resource);
 
         String checksum = checksum(gherkin);
         String path = pathsByChecksum.get(checksum);
         if (path != null) {
-            throw new CucumberException(String.format("Found the same source in %s and %s", path, resource.getPath()));
+            return;
         }
         pathsByChecksum.put(checksum, resource.getPath());
 
+        Formatter formatter = this;
+        if (!filters.isEmpty()) {
+            formatter = new FilterFormatter(this, filters);
+        }
+        Parser parser = new Parser(formatter);
+
         parser.parse(gherkin, resource.getPath(), 0);
         I18n i18n = parser.getI18nLanguage();
         if (currentCucumberFeature != null) {

core/src/test/java/cucumber/runtime/FeatureBuilderTest.java

@@ -10,21 +10,26 @@
 import java.util.List;
 
 import static java.util.Collections.emptyList;
+import static org.junit.Assert.assertEquals;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 public class FeatureBuilderTest {
-    @Test(expected = CucumberException.class)
-    public void detects_duplicate_features() throws IOException {
-        List<CucumberFeature> fearures = new ArrayList<CucumberFeature>();
-        FeatureBuilder builder = new FeatureBuilder(fearures);
+
+    public static final List<Object> NO_FILTERS = emptyList();
+
+    @Test
+    public void ignores_duplicate_features() throws IOException {
+        List<CucumberFeature> features = new ArrayList<CucumberFeature>();
+        FeatureBuilder builder = new FeatureBuilder(features);
         Resource resource = mock(Resource.class);
         when(resource.getPath()).thenReturn("foo.feature");
         ByteArrayInputStream firstFeature = new ByteArrayInputStream("Feature: foo".getBytes("UTF-8"));
         ByteArrayInputStream secondFeature = new ByteArrayInputStream("Feature: foo".getBytes("UTF-8"));
         when(resource.getInputStream()).thenReturn(firstFeature, secondFeature);
-        builder.parse(resource, emptyList());
-        builder.parse(resource, emptyList());
+        builder.parse(resource, NO_FILTERS);
+        builder.parse(resource, NO_FILTERS);
+        assertEquals(1, features.size());
     }
 
 }