Skip to content

Add support for Spring Test @BootstrapWith annotation (new in Spring 4.1) #1061

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
aantono opened this issue Sep 26, 2016 · 1 comment · Fixed by #1245
Closed

Add support for Spring Test @BootstrapWith annotation (new in Spring 4.1) #1061

aantono opened this issue Sep 26, 2016 · 1 comment · Fixed by #1245
Labels
⚡ enhancement Request for new functionality

Comments

@aantono
Copy link

aantono commented Sep 26, 2016

In cucumber.runtime.java.spring.SpringFactory add @BootstrapWith annotation to the supported list by enhancing the annotatedWithSupportedSpringRootTestAnnotations method to be

private boolean annotatedWithSupportedSpringRootTestAnnotations(Class<?> type) {
        return type.isAnnotationPresent(ContextConfiguration.class)
            || type.isAnnotationPresent(ContextHierarchy.class)
            || type.isAnnotationPresent(BootstrapWith.class);
}
This was referenced Sep 26, 2016
Closed
Closed
Closed
@brasmusson brasmusson mentioned this issue Oct 19, 2016
Closed
@sebrose sebrose added ⚡ enhancement Request for new functionality Spring labels Nov 17, 2016
@tan9 tan9 mentioned this issue Feb 15, 2017
Closed
2 tasks
@vipinjose8683 vipinjose8683 mentioned this issue Oct 9, 2017
Closed
mpkorstanje added a commit that referenced this issue Oct 11, 2017
@mpkorstanje
Support BootstrapWith annotation
b25468b 
Fixes #1242, #1061

Spring annotations are hierarchical and can be customized. This
requires that the entire graph is scanned to determine if one of
the supported annotations is present.
@mpkorstanje mpkorstanje mentioned this issue Oct 11, 2017
Merged
6 tasks
mpkorstanje added a commit that referenced this issue Oct 11, 2017
@mpkorstanje
Support BootstrapWith annotation
d9d9d16 
Fixes #1242
Fixes #1061

Spring annotations are hierarchical and can be customized. This
requires that the entire graph is scanned to determine if one of
the supported annotations is present.
mpkorstanje added a commit that referenced this issue Oct 25, 2017
@mpkorstanje
Support BootstrapWith annotation
e1b9583 
Fixes #1242
Fixes #1061

Spring annotations are hierarchical and can be customized. This
requires that the entire graph is scanned to determine if one of
the supported annotations is present.
mlvandijk pushed a commit that referenced this issue Oct 26, 2017
@mpkorstanje @mlvandijk
Support BootstrapWith annotation
359b825 
Fixes #1242
Fixes #1061

Spring annotations are hierarchical and can be customized. This
requires that the entire graph is scanned to determine if one of
the supported annotations is present.
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Spring] Support BootstrapWith annotation cucumber/cucumber-jvm
2 participants
@aantono @sebrose