-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
godog should report failure if ambiguous matching steps are found #635
Comments
@mattwynne hi Matt what's the best way to get a quick conversation on this? I have fixed this in my own local fork to avoid further embarrassment, but I don't have a PR because my other PR 634 is blocking up my GitHub. And 634 needs a whole separate conversation. |
Throwing an error in such case sounds good to me. I think this behavior can be put under |
@vearutop hi take a look - at the related pr Addressed by PR https://github.com/cucumber/godog/pull/636Addressed by PR #636 |
Merged |
@vearutop thanks |
Is there a plan to roll this out? |
I found last week I need to make a fix. |
Also see PR-642 |
Addressed by PR #636
🤔 What's the problem you're trying to solve?
I want my steps to register an error if there are multiple matching steps.
"Ambiguous step def"
✨ What's your proposed solution?
Cause godog to abort if multiple matches are found.
Currentlly it returns the first match so this would be a breaking change for some unsuspecting users of godog.
⛏ Have you considered any alternatives or workarounds?
No response
📚 Any additional context?
This proposal would be consistent with other languages
The text was updated successfully, but these errors were encountered: