Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add when 3.0 compat #157

Closed
briancavalier opened this issue Mar 21, 2014 · 6 comments
Closed

Add when 3.0 compat #157

briancavalier opened this issue Mar 21, 2014 · 6 comments
Milestone

Comments

@briancavalier
Copy link
Member

There were a few breaking API changes in when 3.0 that make it incompatible with wire 0.10. It should be an easy update.

@briancavalier briancavalier added this to the 0.10.7 milestone Mar 21, 2014
@jeffrose
Copy link

I am currently seeing an issue with using wire 010.6 and when 3.0.1. A wire spec that was once working with 0.10.5/2.8.0 has stopped. Here is a quick sample...

{
    appFoo: {
        create: 'foo'
    },
    fooFilter: {
        create: {
            module: 'fooFilter',
            args: {
                $ref: { 'appFoo' }
            }
        }
    },

    $plugins: [ { module: 'wire/debug', trace: true } ]
}

When appFoo is passed into fooFilter it has the value 5000, which of course is not correct. :-)

@briancavalier
Copy link
Member Author

Hey @jeffeose, it's a known incompatibility. We're working on it. The bower.json indicates that you'll need 2.x, and we'll update that when we release a version that's compatible with when 3.0

@briancavalier
Copy link
Member Author

@jeffrose Sorry my last comment sounded kind of gruff, and if my original post wasn't clear--I see now that the way I worded it could imply that wire 0.10.x, where x > 0, are compatible with when 3. Unfortunately, right now all versions of wire are incompatible with all versions when >= 3.0.0. We're targeting next week for a compatibility release.

Thanks for the nice, simple test case as well!

@jeffrose
Copy link

@briancavalier No problem. I did initially think that wire 0.10.6 was compatible with when 3.0.x, which is why I gave it a shot. Looking forward to updated release. :-)

@briancavalier
Copy link
Member Author

Just released wire 0.10.7 which adds when 3.x compatibility. Feel free to open new github issues if you find any problems. Thanks!

@unscriptable
Copy link
Member

woohoo 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants