Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vcpkg support #69

Open
Hary309 opened this issue Apr 7, 2024 · 4 comments
Open

Vcpkg support #69

Hary309 opened this issue Apr 7, 2024 · 4 comments

Comments

@Hary309
Copy link

Hary309 commented Apr 7, 2024

It would be nice to see this library in the vcpkg registry, I hate having deps as a target inside Visual Studio.

Anyway, this is a great library, thanks for your work!

@angelfor3v3r
Copy link
Collaborator

It would be nice to see this library in the vcpkg registry, I hate having deps as a target inside Visual Studio.

Anyway, this is a great library, thanks for your work!

I'm not sure if any of the current maintainers use Vcpkg but I'm sure someone could create a portfile for the library and we wouldn't be against it. My question is though, what's wrong with using the Amalgamated builds? They won't add a target and just live on your include path/in your primary project.

@Hary309
Copy link
Author

Hary309 commented Apr 8, 2024

what's wrong with using the Amalgamated builds? They won't add a target and just live on your include path/in your primary project.

It is even worse to keep the deps sources as part of your primary project 😛 So I would rather move it to a separate target.

@angelfor3v3r
Copy link
Collaborator

what's wrong with using the Amalgamated builds? They won't add a target and just live on your include path/in your primary project.

It is even worse to keep the deps sources as part of your primary project 😛 So I would rather move it to a separate target.

I don't think it's that bad, they're very small files and it keeps it simple, but I understand your concerns and I don't see anything wrong with getting a portfile made for the library. If you have experience with Vcpkg perhaps you could get a simple portfile working to get the ball rolling? 😄

@Hary309
Copy link
Author

Hary309 commented Apr 8, 2024

If you have experience with Vcpkg perhaps you could get a simple portfile working to get the ball rolling? 😄

I don't have any experience with portfiles but this is a good opportunity to learn it finally, I will see what I can do.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants