Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

show_state has stopped working #322

Closed
2 tasks done
jarrah31 opened this issue May 5, 2020 · 6 comments
Closed
2 tasks done

show_state has stopped working #322

jarrah31 opened this issue May 5, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@jarrah31
Copy link

jarrah31 commented May 5, 2020

Checklist

  • I updated the card to the latest version available
  • I cleared the cache of my browser

Describe the bug
If I set show_state to true, I see the following error:
image

This happens with any entity, be it lights, switches, etc. If I set it to false, the error goes away.

If it helps I also see this in the browser dev view:
image

The entity looks like this:
image

It started after I upgraded from 3.3.0-1 to 3.3.2.
Version of the card
Version: 3.3.2
HA version: 106.6

To Reproduce
This is the configuration I used:

      - type: "custom:button-card"
        entity: light.study_desk_lamp
        name: Light
        color_type: icon
        color: auto
        show_label: true
        show_state: true
        show_name: true

Desktop (please complete the following information):

  • Browser [Chrome 81.0.4044.122 and Safari]
@jarrah31 jarrah31 added the bug Something isn't working label May 5, 2020
@RomRider
Copy link
Collaborator

RomRider commented May 5, 2020

Please rollback to 3.3.1 it will fix your issue while I fix it in the code. :)

@jarrah31
Copy link
Author

jarrah31 commented May 5, 2020

super, thanks for the quick response! yep, it works back on 3.3.1. (I did try rolling back to 3.3.0-2 but I that didn't work either, so I suspect I didn't clear the cache after rollback)

@RomRider
Copy link
Collaborator

RomRider commented May 5, 2020

You have to refresh twice if you use HACS, one time is not enough.

@jarrah31
Copy link
Author

jarrah31 commented May 5, 2020

Thank you!

@jarrah31
Copy link
Author

jarrah31 commented May 5, 2020

I couldn't believe no one else had reported the same problem given that show_state would be a fundamental option, but I now realise it was due to my older HA version having seen what you changed to fix it. :)

@RomRider
Copy link
Collaborator

RomRider commented May 5, 2020

Yep, I tried with 0.107, 0.108 and 0.109 before releasing button-card 3.3.2 and it worked, but I didn't try with 0.106 😋

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants