Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for multiple loggers #21

Closed
Redirts opened this issue May 6, 2019 · 3 comments
Closed

Support for multiple loggers #21

Redirts opened this issue May 6, 2019 · 3 comments
Labels
bug Something is broken or not as expected

Comments

@Redirts
Copy link

Redirts commented May 6, 2019

The change made in #5 is not compatible with multiple datasources.
We are using two knex instances (2 DB's) in our project.

Since the variable hasLogger is not a class/object property it will be set true for the first object (knex instance) and will not be initialized for the following ones since hasLogger is already true.
@cvburgess cvburgess added the bug Something is broken or not as expected label May 6, 2019
@cvburgess
Copy link
Owner

thank you! Please open a PR, or hang tight - it may take me several days to get to this

@cvburgess cvburgess changed the title Issue #5 broke logging handling for multiple datasources Support for multiple loggers May 20, 2019
@cvburgess
Copy link
Owner

Is this fixed in v1 for you? we now create the Knex object in the constructor.

@Redirts
Copy link
Author

Redirts commented Sep 18, 2019

Hi,

In the meanwhile I stopped using SQLDataSource so I cannot test it anymore unfortunately...

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something is broken or not as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvburgess @Redirts