Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

maybe a shape bug in create_dataset_from_pano.py? #10

Open
JizheXIA opened this issue Nov 20, 2024 · 2 comments
Open

maybe a shape bug in create_dataset_from_pano.py? #10

JizheXIA opened this issue Nov 20, 2024 · 2 comments

Comments

@JizheXIA
Copy link

JizheXIA commented Nov 20, 2024

in https://github.com/cvg/GeoCalib/blob/main/siclib/geometry/base_camera.py#L471:
pano_shape = (int(pano_img.shape[0] * scale), int(pano_img.shape[1] * scale))

but pano_img is a Bx3xHxW tensor, maybe there should be "pano_img.shape[2]" and "pano_img.shape[3]" instead of "pano_img.shape[0]" and "pano_img.shape[1]"?

@sarlinpe
Copy link
Member

Good catch, thank you! @veichta knows more about this part of the code.

@veichta
Copy link
Collaborator

veichta commented Nov 26, 2024

Thank you for pointing this out! It should be fixed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants