Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

19-Oct-21 Peer-To-Peer Code Review #4

Open
JEFFKAY16 opened this issue Oct 19, 2021 · 0 comments
Open

19-Oct-21 Peer-To-Peer Code Review #4

JEFFKAY16 opened this issue Oct 19, 2021 · 0 comments

Comments

@JEFFKAY16
Copy link

Hi Ricky, the project and codebase look very neat and professional- excellent work. We have opened an issue highlighting ways the codebase may be improved.

  • The navigation links found here could be improved by wrapping them in a nav tag which helps in the SEO process as a result of semantics.
  • In order to keep our main navbar in the main focus we would suggest wrapping this nav content inside the aside tag so that SEO searches focus on your main navigation lists.
  • Try not to import these files to your CSS file, since it prevents the page to load smoothly, instead, you could attach the same file into your HTML file inside the head tag wrapped in a link tag.
  • This and this line here would be removed so as to avoid repetition since the font-family was applied to the body tag/better still it would be applied to a * selector.
  • The icons in the program section aren't aligned in the center.
  • You did a great job using one JavaScript file for both pages- Something I just learned.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant