Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Latest version of Logestic still not running with Elysia 1.1.3 #33

Closed
Ripwords opened this issue Jul 20, 2024 · 4 comments · Fixed by #34
Closed

Latest version of Logestic still not running with Elysia 1.1.3 #33

Ripwords opened this issue Jul 20, 2024 · 4 comments · Fixed by #34
Labels
bug Something isn't working

Comments

@Ripwords
Copy link
Contributor

What version of Logestic are you using?

v1.2.1

What is the bug and how to reproduce it?

Install Logestic v1.2.1 with an Elysia 1.1.3 project, run dev, and elysia doesn't run

What is the expected behaviour?

Elysia runs with Logestic

Any additional information/media?

  1. Runs with Logestic using preview folder from this repo i forked
    image

  2. Running without Logestic
    image

@Ripwords Ripwords added the bug Something isn't working label Jul 20, 2024
@cybercoder-naj
Copy link
Owner

I experienced this last night as well. If you copy over the files as-is, Elysia runs. I suspect bun build is causing an issue. It is strange since I have no clue where it error is coming from (as of today). There are no such major changes in #32 that could cause this. I'll research and investigate over the weekend. If you find something as well, feel free to drop it in here/open a PR.

@cybercoder-naj
Copy link
Owner

cybercoder-naj commented Jul 20, 2024

Edit, the --minify flag of bun build has some error. Issue reported here

@Ripwords
Copy link
Contributor Author

Ripwords commented Jul 20, 2024

@cybercoder-naj

https://bun.sh/docs/bundler#minify

Using the granular minification configuration I've identified that the cause is --minify-identifiers as adding --minify-whitespace and --minify-syntax both allows for a build that runs successfully

@Ripwords
Copy link
Contributor Author

Possibly related to oven-sh/bun#9474

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants