Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

append (failed) to video filenames when test fails #6998

Closed
dnaverdo opened this issue Apr 13, 2020 · 1 comment
Closed

append (failed) to video filenames when test fails #6998

dnaverdo opened this issue Apr 13, 2020 · 1 comment
Labels
topic: video 📹 type: duplicate This issue or pull request already exists

Comments

@dnaverdo
Copy link

dnaverdo commented Apr 13, 2020

Current behavior:

Video files do not indicate if the screenshot is a failing test like screenshots do.

Desired behavior:

The videos that are taken during failure are named the same name as the test it failed within with (failed) appended to the filename, so you can detect the ones during failure. This PR added the (failed) functionality for screenshots: #1858

Test code to reproduce

  1. fail a test that has screenshots and videos
  2. observe filenames of video and screenshot

Versions

all

@dnaverdo dnaverdo changed the title add (failed) to screenshot filenames when test fails similar to videos add (failed) to vidoe filenames when test fails similar to screenshots Apr 13, 2020
@dnaverdo dnaverdo changed the title add (failed) to vidoe filenames when test fails similar to screenshots append (failed) to video filenames when test fails similar to screenshots Apr 13, 2020
@dnaverdo dnaverdo changed the title append (failed) to video filenames when test fails similar to screenshots append (failed) to video filenames when test fails Apr 13, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Apr 14, 2020
@jennifer-shehane jennifer-shehane added type: enhancement Requested enhancement of existing feature topic: video 📹 labels Apr 14, 2020
@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label Aug 3, 2020
@jennifer-shehane
Copy link
Member

We've had some discussion about this feature request and feel that this would be better served under the larger feature requested in #2522

Our thinking being that people essentially want to not save the non-passing test videos, which could be achieved in #2522 as opposed to just adding a string to the video and still leaving it up to people to implement the deletion.

Appending the (failed) string may still be part of that larger work - we haven't decided, so opinions are welcome if you'd like to comment within here or in #2522.

@jennifer-shehane jennifer-shehane added type: duplicate This issue or pull request already exists and removed good first issue Good for newcomers stage: ready for work The issue is reproducible and in scope type: enhancement Requested enhancement of existing feature labels Aug 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: video 📹 type: duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants