refactor: lifts toPosix to its own file, removes circular dependency between stack_utils and source_map_utils #30983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tils and source_map_utils
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cacie/refactor/stack-sourcemap-circular
|
| Run status |
|
| Run duration | 17m 44s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
11
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26546
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.43%
|
|
|---|---|
|
Untested elements
|
192
|
|
Tested elements
|
164
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
890
|
jennifer-shehane
approved these changes
Jan 30, 2025
|
@cacieprins Hmm, a lot of weird failures on this one https://cloud.cypress.io/projects/ypt4pf/runs/60150/overview |
Bizarre.. I'll table this refactor for now |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Lifts the function from
stack_utilsthatsource_map_utilswas using to its own file. This enables the removal of thestack_utils.ts<->source_map_utilscycle. Vitest unit tests are added as well.This utility is recreated several times across the repo. Perhaps a single third party npm package, like
unixifyornormalize-pathwould be helpful.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?