Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactoring PR #5

Closed
black7375 opened this issue May 30, 2021 · 2 comments
Closed

Refactoring PR #5

black7375 opened this issue May 30, 2021 · 2 comments

Comments

@black7375
Copy link
Contributor

I was impressed with your project and did some refactoring.

Changes

  • Use Typescript
  • Modulize: For example, applyEffect is close to 150 lines now)
  • API applied to single element(applySingleEffect): I made it for personal needs, and the main use case is when a new element is created. Roadmap black7375/Firefox-UI-Fix#2 (comment) [New Tab Handler]
  • Maybe a little optimization: Reduced the number of offsets.

Code is here.
I will prepare PR if you want.
@d2phap
Copy link
Owner

d2phap commented May 30, 2021

Hi @black7375
Thanks for your contribution, I was also working on a typescript version in the past few weeks, but I haven't completed yet.

@black7375
Copy link
Contributor Author

I'll submit it within next week.

@black7375 black7375 mentioned this issue Jun 8, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d2phap @black7375