Skip to content

🧪 Handle version inputs that start with v #104

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
jpadams opened this issue Nov 15, 2023 · 4 comments
Open

🧪 Handle version inputs that start with v #104

jpadams opened this issue Nov 15, 2023 · 4 comments

Comments

@jpadams
Copy link
Contributor

jpadams commented Nov 15, 2023

curl -sL https://dl.dagger.io/dagger/install.sh 2>/dev/null | \
        DAGGER_VERSION='v0.9.2' sh
sh debug downloading files into /var/folders/s4/xyj9q5ps2ys3rc9nsps1v20m0000gn/T/tmp.tTShNB7AUU
sh debug http_download https://dl.dagger.io/dagger/releases/v0.9.2/dagger_vv0.9.2_darwin_arm64.tar.gz
sh debug http_download_curl received HTTP status 403

errors out because of extra v. Could be solved be removing the v here or could also be fixed upstream in the installer script, which might be better.

@jpadams jpadams changed the title 🧪 Handle version inputs that start with v by dropping v 🧪 Handle version inputs that start with v Nov 15, 2023
@purpleclay
Copy link
Contributor

I have raised an MR to fix this in the install.sh script, dagger/dagger#7010

@purpleclay
Copy link
Contributor

@jpadams just to let you know, my fix to the install script has been merged in. So, in theory, this ticket could be closed?

@lukemarsden
Copy link

yup, we should do a release to get this fix into the hands of users - I had the same issue :)

@jpadams
Copy link
Contributor Author

jpadams commented Dec 22, 2024

this is fixed upstream, but we'll normalize our version internally to remove the leading v to ensure we get consistent results when checking for existing dagger install as in #164

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants