Connection options aren’t consistently named

[bfontaine]

👋 Hi again!

I just found a bug in our codebase because someone used :conn-manager instead of :connection-manager for some requests.

This is probably because there are already two options starting with :conn-: :conn-timeout and :conn-request-timeout.

I’d like to make a pull-request to uniformize those names:

• Option 1: :conn-timeout, :conn-request-timeout, and :conn-manager
• Option 2: :connection-timeout, :connection-request-timeout, and :connection-manager

Which option would be the best for you? I can also keep the current key(s) for backward compatibility.

[dakrone]

Hi @bfontaine,

I agree that we should be consistent here. My preference is probably for the fully-spelled version (:connection-timeout for example), I definitely think we should keep the current ones for backwards compatibility.

Perhaps clj-http.util/opt could be extended so multiple parameters can be passed to it and it will use either?

A PR would be most welcome!

[bfontaine]

I made a PR: #478