Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🚀Support --color-moved-ws #144

Closed
andrey-bolduzev opened this issue Apr 28, 2020 · 5 comments
Closed

🚀Support --color-moved-ws #144

andrey-bolduzev opened this issue Apr 28, 2020 · 5 comments

Comments

@andrey-bolduzev
Copy link

I'm personally interested in --color-moved-ws=allow-indentation-change which in combination with --colorMoved=dimmed_zebra (or similar) is a great way of enabling pure indentation changes to not be marked as 20 lines removed and 20 lines added.

@dandavison
Copy link
Owner

Thanks for the proposal @andrey-bolduzev! Linking #72 but I know that you've seen that one already :)

@andrey-bolduzev
Copy link
Author

Thanks for the proposal @andrey-bolduzev! Linking #72 but I know that you've seen that one already :)

Thank you! Yes, I had that feature proposal in mind but I figured I would log another one since --color-moved-ws is somewhat different.

@dandavison dandavison changed the title Support --color-moved-ws 🚀Support --color-moved-ws Apr 29, 2020
@dandavison
Copy link
Owner

Just to be totally explicit, this feature request only becomes relevant if #72 is implemented, right? (I'm trying to plan work on existing issues).

@andrey-bolduzev
Copy link
Author

Just to be totally explicit, this feature request only becomes relevant if #72 is implemented, right? (I'm trying to plan work on existing issues).

I think you're correct. I just played with it, and --color-moved-ws seems to have no visible effect without --color-moved also set. Thank you.

@dandavison
Copy link
Owner

Hi @andrey-bolduzev, this is fixed in master and will be released soon. Detailed notes here: #72 (comment). (If it's easy for you to build Delta on master and check it's working for you, that's always very helpful.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants