Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create chartViewDidEndAnimate in ChartViewDelegate #3852

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

Lcsmarcal
Copy link
Contributor

@Lcsmarcal Lcsmarcal commented Feb 20, 2019

Goals ⚽

Create a callback to get when ChartView stops animating

Implementation Details 🚧

Create another function in ChartViewDelegate protocol and calls in animatorStopped callback from Animator

@codecov-io
Copy link

Codecov Report

Merging #3852 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3852   +/-   ##
=======================================
  Coverage   32.79%   32.79%           
=======================================
  Files         114      114           
  Lines       10731    10731           
=======================================
  Hits         3519     3519           
  Misses       7212     7212
Impacted Files Coverage Δ
Source/Charts/Charts/ChartViewBase.swift 23.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf36285...a323ad0. Read the comment docs.

@liuxuan30
Copy link
Member

@jjatie what you say? I'm fine

@jjatie
Copy link
Collaborator

jjatie commented Mar 4, 2019

I would think the delegate would include more information. This naming would also be more clear.

func chartView(_ chartView: ChartViewBase, animatorDidStop animator: Animator)

@liuxuan30
Copy link
Member

@Lcsmarcal please have a look

@Lcsmarcal
Copy link
Contributor Author

Sure! I will add the animator in function.

@Lcsmarcal
Copy link
Contributor Author

Done :)

@liuxuan30 liuxuan30 merged commit b1df472 into ChartsOrg:master Mar 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants