Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

notcurses doesn't build on mojave #2001

Closed
dankamongmen opened this issue Jul 29, 2021 · 2 comments
Closed

notcurses doesn't build on mojave #2001

dankamongmen opened this issue Jul 29, 2021 · 2 comments
Assignees
@dankamongmen
Labels
bug Something isn't working macOS
Milestone
2.4.0

Comments

@dankamongmen
Copy link
Owner

See Homebrew/homebrew-core#82112. We're failing due to a missing std::filesystem and header.
@dankamongmen dankamongmen added the bug Something isn't working label Jul 29, 2021
@dankamongmen dankamongmen self-assigned this Jul 29, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jul 29, 2021
@dankamongmen dankamongmen mentioned this issue Jul 29, 2021
Closed
6 tasks
@dankamongmen
Copy link
Owner Author

note that if we were to resolve #1720, we would technically "resolve" this issue, though we wouldn't be building ncls on Mojave. i'm not sure we can give different cmake arguments based off the build target in Homebrew...

@dankamongmen
Copy link
Owner Author

alright, i've removed the use of filesystem in ncls/*.cpp. since we don't build notcurses-tester in Homebrew, this will get all of it. we can go ahead and remove the no-mojave tag when we release 2.3.13.

@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working macOS
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@dankamongmen