New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

drop dependencies from dmap.js #113

Open

nmushegian opened this issue May 3, 2022 · 1 comment

Member

nmushegian commented May 3, 2022

ethers

ethers.utils.defaultAbiCoder
- we only need to encode one call, get
ethers.utils.keccak256
- find a standalone implementation
ethers.utils.hexZeroPad
- just extract this function
ethers.BigNumber.from
- use native BigInteger
ethers.utils.Interface
- pretty sure lib.slot is deprecated now?

ebnf

the parser for dpath should be trivial

Contributor

dmfxyz commented May 4, 2022

ethers.utils.keccak256: We can use https://www.npmjs.com/package/keccak, or do we prefer to write our own implementation from scratch?
ethers.utils.defaultAbiCoder should be able to write this ourselves for the basic encode call. Would like to keep ethers around to differentially test though, at least at the start.
ethers.utils.hexZeroPad ack on extraction
ethers.BigNumber.from ack on using native

Have to look into lib.slot more to make sure I fully understand how it's being used.

stobiewan mentioned this issue

remove ebnf and disallow digits in dpath #116

Closed

dmfxyz mentioned this issue

Remove Ethers Dependencies #117

Merged

8 tasks

# for free to join this conversation on GitHub. Already have an account? # to comment