Skip to content

Secretstore: GCP Secrets Manager to support implicit credentials #945

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
tholcman opened this issue Jun 16, 2021 · 5 comments
Closed

Secretstore: GCP Secrets Manager to support implicit credentials #945

tholcman opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
kind/enhancement New feature or request pinned Issue does not get stale

Comments

@tholcman
Copy link

Support implicit credentials (f.e. Workload Identity in k8s) for GCP Secrets Manager client creation like it does for pubsub client:

this function
https://github.com/dapr/components-contrib/blob/master/secretstores/gcp/secretmanager/secretmanager.go#L66

should be similar to this one
https://github.com/dapr/components-contrib/blob/master/pubsub/gcp/pubsub/pubsub.go#L152

@tholcman tholcman added the kind/enhancement New feature or request label Jun 16, 2021
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Jul 28, 2021
@dapr-bot
Copy link
Collaborator

dapr-bot commented Aug 4, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@dapr-bot dapr-bot closed this as completed Aug 4, 2021
@tholcman
Copy link
Author

tholcman commented Aug 5, 2021

Please don't close this feature request, I guess it is important for security and also for consistency - pubsub component supports, it should be supported also by secrets component!

@alicejgibbons
Copy link

@antontroshin should these also be merged into master?

@antontroshin
Copy link
Contributor

@alicejgibbons sorry for the delay. The PR to merge into main is here #3790

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/enhancement New feature or request pinned Issue does not get stale
Projects
Status: Done
Development

No branches or pull requests

5 participants