fix: ignore method invocations in a variable declaration for prefer-moving-to-variable (#1144)

Author: incendial

CHANGELOG.md

@@ -7,6 +7,7 @@
 * feat: exclude `.freezed.dart` files by default.
 * fix: handle try and switch statements for [`use-setstate-synchronously`](https://dartcodemetrics.dev/docs/rules/flutter/use-setstate-synchronously)
 * chore: restrict `analyzer` version to `>=5.1.0 <5.4.0`.
+* fix: ignore method invocations in a variable declaration for [`prefer-moving-to-variable`](https://dartcodemetrics.dev/docs/rules/common/prefer-moving-to-variable).
 * feat: add `allow-initialized` option to [`avoid-late-keyword`](https://dartcodemetrics.dev/docs/rules/common/avoid-late-keyword).
 
 ## 5.4.0

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/visitor.dart

@@ -61,6 +61,7 @@ class _BlockVisitor extends RecursiveAstVisitor<void> {
   @override
   void visitMethodInvocation(MethodInvocation node) {
     if (node.parent is CascadeExpression ||
+        node.parent is VariableDeclaration ||
         (node.staticType?.isVoid ?? false)) {
       return;
     }

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/examples/assignment_example.dart

@@ -0,0 +1,8 @@
+void main() {
+  final var1 = someFunction();
+  final var2 = someFunction();
+}
+
+String someFunction() {
+  return 'qwe';
+}

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/prefer_moving_to_variable_rule_test.dart

@@ -15,6 +15,8 @@ const _cascadeExamplePath =
     'prefer_moving_to_variable/examples/cascade_example.dart';
 const _genericsExamplePath =
     'prefer_moving_to_variable/examples/generics_example.dart';
+const _assignmentExamplePath =
+    'prefer_moving_to_variable/examples/assignment_example.dart';
 const _prefixExamplePath =
     'prefer_moving_to_variable/examples/prefix_example.dart';
 
@@ -217,6 +219,13 @@ void main() {
       RuleTestHelper.verifyNoIssues(issues);
     });
 
+    test('reports no issues for assignments', () async {
+      final unit = await RuleTestHelper.resolveFromFile(_assignmentExamplePath);
+      final issues = PreferMovingToVariableRule().check(unit);
+
+      RuleTestHelper.verifyNoIssues(issues);
+    });
+
     test('reports no issues for generics', () async {
       final unit = await RuleTestHelper.resolveFromFile(_genericsExamplePath);
       final issues = PreferMovingToVariableRule().check(unit);