Skip to content

Build UI for linked edit groups #1213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
RedBrogdon opened this issue Aug 19, 2019 · 1 comment
Closed

Build UI for linked edit groups #1213

RedBrogdon opened this issue Aug 19, 2019 · 1 comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone
Backlog

Comments

@RedBrogdon
Copy link
Contributor

The Dart analyzer is capable of producing LinkedEditGroups to use after implementing assists/fixes. These are post-fix edits in which devs can modify the name of a just-injected widget, new class, etc.

The data for the groups is now retrieved by dart-services and sent down to dart-pad (dart-archive/dart-services#442). We need to update dart-pad to correctly guide users through any linked edit groups associated with a fix they apply, similar to the way IntelliJ puts a border around newly injected code:

image
@RedBrogdon RedBrogdon added P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug labels Aug 19, 2019
@RedBrogdon RedBrogdon added this to the Backlog milestone Aug 19, 2019
This was referenced Aug 19, 2019
Merged
Closed
@parlough
Copy link
Member

Closing this due to the reduced scope of DartPad's frontend. If anyone would still like to see this implemented, please open a new issue with your use case outlined. Thanks so much!!

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@parlough parlough added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jun 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@RedBrogdon @parlough