Skip to content

Commit a1d3005

Browse files
committed
Fix cross-export warning calculation:
1 parent 2943545 commit a1d3005

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/src/model/model_element.dart

+3-2
Original file line numberDiff line numberDiff line change
@@ -541,9 +541,10 @@ abstract class ModelElement extends Canonicalization
541541

542542
// Avoid claiming canonicalization for elements outside of this element's
543543
// defining package.
544-
// TODO(jcollins-g): Make the else block unconditional.
544+
// TODO(srawlins): Make the else block unconditional, so that we always
545+
// exclude cross-package exports.
545546
if (candidateLibraries.isNotEmpty &&
546-
!candidateLibraries.any((l) => l.package == definingLibrary.package)) {
547+
candidateLibraries.any((l) => l.package != definingLibrary.package)) {
547548
warn(PackageWarning.reexportedPrivateApiAcrossPackages,
548549
message: definingLibrary.package.fullyQualifiedName,
549550
referredFrom: candidateLibraries);

0 commit comments

Comments
 (0)