Skip to content

Commit 995e0f0

Browse files
author
John Messerly
committed
remove #177 workaround
this issue was fixed R=vsm@google.com Review URL: https://codereview.chromium.org/1142553002
1 parent 3377d2b commit 995e0f0

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

pkg/dev_compiler/lib/runtime/dart/_isolate_helper.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -778,12 +778,13 @@ var async = dart.import(async);
778778
}
779779
[_runHelper]() {
780780
if (exports.globalWindow != null) {
781+
// Function next: () → dynamic
781782
let next = (() => {
782783
if (!dart.notNull(this.runIteration()))
783784
return;
784-
async.Timer.run(dart.as(next, __CastType2));
785+
async.Timer.run(next);
785786
}).bind(this);
786-
dart.dcall(next);
787+
next();
787788
} else {
788789
while (this.runIteration()) {
789790
}
@@ -1381,7 +1382,6 @@ var async = dart.import(async);
13811382
}
13821383
CapabilityImpl[dart.implements] = () => [isolate.Capability];
13831384
dart.defineNamedConstructor(CapabilityImpl, '_internal');
1384-
let __CastType2 = dart.typedef('__CastType2', () => dart.functionType(dart.void, []));
13851385
// Exports:
13861386
exports.enterJsAsync = enterJsAsync;
13871387
exports.leaveJsAsync = leaveJsAsync;

pkg/dev_compiler/test/generated_sdk/lib/_internal/compiler/js_lib/isolate_helper.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -652,12 +652,10 @@ class _EventLoop {
652652
void _runHelper() {
653653
if (globalWindow != null) {
654654
// Run each iteration from the browser's top event loop.
655-
// TODO(vsm): Revert to original pattern.
656-
// See: https://github.com/dart-lang/dev_compiler/issues/177
657-
Function next = () {
655+
next() {
658656
if (!runIteration()) return;
659657
Timer.run(next);
660-
};
658+
}
661659
next();
662660
} else {
663661
// Run synchronously until no more iterations are available.

pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -652,12 +652,10 @@ class _EventLoop {
652652
void _runHelper() {
653653
if (globalWindow != null) {
654654
// Run each iteration from the browser's top event loop.
655-
// TODO(vsm): Revert to original pattern.
656-
// See: https://github.com/dart-lang/dev_compiler/issues/177
657-
Function next = () {
655+
next() {
658656
if (!runIteration()) return;
659657
Timer.run(next);
660-
};
658+
}
661659
next();
662660
} else {
663661
// Run synchronously until no more iterations are available.

0 commit comments

Comments
 (0)