Fix an exception in the changeArgumentName quick fix (issue 36440)

Change-Id: Ide70f8535798829e208b482c79c6f97cd414a829
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98438
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Author: bwilkerson

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -1146,7 +1146,7 @@ class FixProcessor {
           sessionHelper,
           namedExpression.parent.parent,
         );
-        return parameters.namedNames;
+        return parameters?.namedNames;
       }
       return null;
     }
@@ -4541,11 +4541,15 @@ class _ExecutableParameters {
   factory _ExecutableParameters(
       AnalysisSessionHelper sessionHelper, AstNode invocation) {
     Element element;
-    if (invocation is InstanceCreationExpression) {
+    // This doesn't handle FunctionExpressionInvocation.
+    if (invocation is Annotation) {
+      element = invocation.element;
+    } else if (invocation is InstanceCreationExpression) {
       element = invocation.staticElement;
-    }
-    if (invocation is MethodInvocation) {
+    } else if (invocation is MethodInvocation) {
       element = invocation.methodName.staticElement;
+    } else if (invocation is ConstructorReferenceNode) {
+      element = invocation.staticElement;
     }
     if (element is ExecutableElement && !element.isSynthetic) {
       return new _ExecutableParameters._(sessionHelper, element);

pkg/analysis_server/test/src/services/correction/fix/change_argument_name_test.dart

@@ -117,6 +117,23 @@ class A {
 ''');
   }
 
+  test_default_annotation() async {
+    await resolveTestUnit('''
+@A(boot: 2)
+f() => null;
+class A {
+  const A({int boat});
+}
+''');
+    await assertHasFix('''
+@A(boat: 2)
+f() => null;
+class A {
+  const A({int boat});
+}
+''');
+  }
+
   test_default_constructor() async {
     await resolveTestUnit('''
 f() => new A(boot: 2);
@@ -166,6 +183,40 @@ class A {
 ''');
   }
 
+  test_default_redirectingConstructor() async {
+    await resolveTestUnit('''
+class A {
+  A.one() : this.two(boot: 3);
+  A.two({int boat});
+}
+''');
+    await assertHasFix('''
+class A {
+  A.one() : this.two(boat: 3);
+  A.two({int boat});
+}
+''');
+  }
+
+  test_default_superConstructor() async {
+    await resolveTestUnit('''
+class A {
+  A.a({int boat});
+}
+class B extends A {
+  B.b() : super.a(boot: 3);
+}
+''');
+    await assertHasFix('''
+class A {
+  A.a({int boat});
+}
+class B extends A {
+  B.b() : super.a(boat: 3);
+}
+''');
+  }
+
   test_tooDistant_constructor() async {
     await resolveTestUnit('''
 f() => new A(bbbbb: 2);