[cfe] Handle callable extension getters

Closes #40596
Closes #40713
Closes #39889

Change-Id: I183560b912e2f6f2c02d51278c0d28c8a6d67f99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139203
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>

Author: johnniwinther

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -641,8 +641,9 @@ class BodyBuilder extends ScopeListener<JumpTarget>
           (expression is! ReadOnlyAccessGenerator ||
               expression is TypeUseGenerator ||
               expression is ParenthesizedExpressionGenerator)) {
-        push(wrapInProblem(
-            toValue(expression), fasta.messageExpressionNotMetadata, noLength));
+        Expression value = toValue(expression);
+        push(wrapInProblem(value, fasta.messageExpressionNotMetadata,
+            value.fileOffset, noLength));
       } else {
         push(toValue(expression));
       }
@@ -860,8 +861,8 @@ class BodyBuilder extends ScopeListener<JumpTarget>
     } else {
       Expression value = toValue(node);
       if (!forest.isThrow(node)) {
-        value =
-            wrapInProblem(value, fasta.messageExpectedAnInitializer, noLength);
+        value = wrapInProblem(value, fasta.messageExpectedAnInitializer,
+            value.fileOffset, noLength);
       }
       initializers = <Initializer>[
         buildInvalidInitializer(node, token.charOffset)
@@ -3679,8 +3680,9 @@ class BodyBuilder extends ScopeListener<JumpTarget>
       push(generator.buildPrefixIncrement(incrementOperator(token),
           offset: token.charOffset));
     } else {
+      Expression value = toValue(generator);
       push(wrapInProblem(
-          toValue(generator), fasta.messageNotAnLvalue, noLength));
+          value, fasta.messageNotAnLvalue, value.fileOffset, noLength));
     }
   }
 
@@ -3692,8 +3694,9 @@ class BodyBuilder extends ScopeListener<JumpTarget>
       push(new DelayedPostfixIncrement(
           this, token, generator, incrementOperator(token)));
     } else {
+      Expression value = toValue(generator);
       push(wrapInProblem(
-          toValue(generator), fasta.messageNotAnLvalue, noLength));
+          value, fasta.messageNotAnLvalue, value.fileOffset, noLength));
     }
   }
 
@@ -5465,16 +5468,16 @@ class BodyBuilder extends ScopeListener<JumpTarget>
   }
 
   @override
-  Expression wrapInProblem(Expression expression, Message message, int length,
+  Expression wrapInProblem(
+      Expression expression, Message message, int fileOffset, int length,
       {List<LocatedMessage> context}) {
-    int charOffset = expression.fileOffset;
     Severity severity = message.code.severity;
     if (severity == Severity.error) {
       return wrapInLocatedProblem(
-          expression, message.withLocation(uri, charOffset, length),
+          expression, message.withLocation(uri, fileOffset, length),
           context: context);
     } else {
-      addProblem(message, charOffset, length, context: context);
+      addProblem(message, fileOffset, length, context: context);
       return expression;
     }
   }

pkg/front_end/lib/src/fasta/kernel/inference_visitor.dart

@@ -741,8 +741,8 @@ class InferenceVisitor
           inferrer.library.addProblem(messageDefaultListConstructorWarning,
               node.fileOffset, noLength, inferrer.helper.uri);
         } else {
-          resultNode = inferrer.helper.wrapInProblem(
-              node, messageDefaultListConstructorError, noLength);
+          resultNode = inferrer.helper.wrapInProblem(node,
+              messageDefaultListConstructorError, node.fileOffset, noLength);
         }
       }
     }
@@ -2362,6 +2362,7 @@ class InferenceVisitor
                   invocationResult.expression..fileOffset = node.fileOffset,
                   templateNullableExpressionCallError.withArguments(
                       receiverType, inferrer.isNonNullableByDefault),
+                  node.fileOffset,
                   noLength));
         }
       }
@@ -3605,6 +3606,7 @@ class InferenceVisitor
                       binaryName.name,
                       leftType,
                       inferrer.isNonNullableByDefault),
+                  binary.fileOffset,
                   binaryName.name.length));
         }
       }
@@ -3696,6 +3698,7 @@ class InferenceVisitor
                       unaryName.name,
                       expressionType,
                       inferrer.isNonNullableByDefault),
+                  unary.fileOffset,
                   unaryName == unaryMinusName ? 1 : unaryName.name.length));
         }
       }
@@ -3777,6 +3780,7 @@ class InferenceVisitor
                       indexGetName.name,
                       receiverType,
                       inferrer.isNonNullableByDefault),
+                  read.fileOffset,
                   noLength));
         }
       }
@@ -3835,6 +3839,7 @@ class InferenceVisitor
               write,
               templateNullableOperatorCallError.withArguments(indexSetName.name,
                   receiverType, inferrer.isNonNullableByDefault),
+              write.fileOffset,
               noLength);
         }
       }
@@ -3964,6 +3969,7 @@ class InferenceVisitor
                       propertyName.name,
                       receiverType,
                       inferrer.isNonNullableByDefault),
+                  read.fileOffset,
                   propertyName.name.length));
         }
       }
@@ -4045,6 +4051,7 @@ class InferenceVisitor
                   propertyName.name,
                   receiverType,
                   inferrer.isNonNullableByDefault),
+              write.fileOffset,
               propertyName.name.length);
         }
       }
@@ -5553,6 +5560,7 @@ class InferenceVisitor
                     node,
                     templateNonNullableNotAssignedError
                         .withArguments(node.variable.name),
+                    node.fileOffset,
                     node.variable.name.length));
           }
         }

pkg/front_end/lib/src/fasta/type_inference/inference_helper.dart

@@ -26,7 +26,8 @@ abstract class InferenceHelper {
   void addProblem(Message message, int charOffset, int length,
       {List<LocatedMessage> context, bool wasHandled});
 
-  Expression wrapInProblem(Expression expression, Message message, int length,
+  Expression wrapInProblem(
+      Expression expression, Message message, int fileOffset, int length,
       {List<LocatedMessage> context});
 
   String constructorNameForDiagnostics(String name,