Skip to content

Commit a73dec2

Browse files
committed
Fix checked mode error
R=jmesserly@google.com Review URL: https://codereview.chromium.org/1167543002
1 parent 526ac2e commit a73dec2

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

pkg/dev_compiler/lib/src/dependency_graph.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ class HtmlSourceNode extends SourceNode {
154154
/// Libraries referred to via script tags.
155155
Set<DartSourceNode> scripts = new Set<DartSourceNode>();
156156

157-
/// Link-rel stylesheets and images.
158-
Set<ResourceSourceNode> resources = new Set<ResourceSourceNode>();
157+
/// Link-rel stylesheets, images, and other specified files.
158+
Set<SourceNode> resources = new Set<SourceNode>();
159159

160160
@override
161161
Iterable<SourceNode> get allDeps =>
@@ -199,7 +199,7 @@ class HtmlSourceNode extends SourceNode {
199199
scripts = newScripts;
200200
}
201201

202-
var newResources = new Set<ResourceSourceNode>();
202+
var newResources = new Set<SourceNode>();
203203
for (var resource in graph.resources) {
204204
newResources.add(graph.nodeFromUri(uri.resolve(resource)));
205205
}

pkg/dev_compiler/lib/src/options.dart

+4-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,10 @@ CompilerOptions parseOptions(List<String> argv) {
311311
useMultiPackage: args['use-multi-package'],
312312
packageRoot: args['package-root'],
313313
packagePaths: args['package-paths'].split(','),
314-
resources: args['resources'].split(','),
314+
resources: args['resources']
315+
.split(',')
316+
.where((s) => s.isNotEmpty)
317+
.toList(),
315318
inferDownwards: args['infer-downwards'],
316319
inferFromOverrides: args['infer-from-overrides'],
317320
inferTransitively: args['infer-transitively'],

0 commit comments

Comments
 (0)