Skip to content

pub run should save snapshots of dependencies' executables #20482

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
nex3 opened this issue Aug 12, 2014 · 5 comments
Closed

pub run should save snapshots of dependencies' executables #20482

nex3 opened this issue Aug 12, 2014 · 5 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Aug 12, 2014

As long as a dependency doesn't transitively depend on the root package or a path dependency, that dependency's executables should be precompiled on "pub get"/"pub upgrade" and cached as VM snapshots.

Since snapshots aren't compatible across VM versions. If possible, we should detect version incompatibility by trying and failing to run a newer VM on an older snapshot.

@nex3
Copy link
Member Author

nex3 commented Aug 20, 2014

r39424 mostly implements this, but there are a few details I want to improve before closing out the bug.

@DartBot
Copy link

DartBot commented Aug 21, 2014

This comment was originally written by @zoechi


Please don't forget to add a note that .pub/ should be added to .gitignore

@DartBot
Copy link

DartBot commented Aug 21, 2014

This comment was originally written by @zoechi


Performance is fine now !

@nex3
Copy link
Member Author

nex3 commented Aug 25, 2014

Fixed by r39424, r39431, r39441, and r39528.


Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1087.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants