Skip to content

[dart2js] Implement support for dynamic checks on parameters that are covariant-by-declaration due to inheritance #47076

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
eernstg opened this issue Sep 1, 2021 · 9 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@eernstg
Copy link
Member

eernstg commented Sep 1, 2021

This is the dart2js specific issue for #47072, which has the details.

@eernstg eernstg added web-dart2js area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Sep 1, 2021
@devoncarew
Copy link
Member

devoncarew commented Sep 2, 2021

@rakudrama (or @sigmundch) - can you provide a very rough estimate of how long this would take to do? We're trying to get breadbox estimates of the ~5 impl. tasks for this language change.

(updated to reference the correct github account)

@sigmundch
Copy link
Member

@rakudrama (our apologies for the spam @sra)

@rakudrama
Copy link
Member

It would be useful to have a sketch of how the CFE will present the additional checks.

@devoncarew
Copy link
Member

cc @johnniwinther

@johnniwinther
Copy link
Member

I'm working on a CL that'll add explicit AsExpressions to the already generated forwarding stub. Some of the stubs are skipped by dart2js so we might need to fix that.

@devoncarew
Copy link
Member

@sigmundch - can you assign the right owner for this? Thanks!

@sigmundch
Copy link
Member

Thanks @devoncarew, will follow up shortly after our team sync.

@johnniwinther - are the CFE representation changes in place?

@sigmundch
Copy link
Member

quick update - @johnniwinther will be looking first at whether the lowering in the CFE needs any additional work, and will reassign it to us once it's ready for us to take a look.

@sigmundch sigmundch assigned johnniwinther and unassigned sigmundch Oct 7, 2021
@sigmundch sigmundch added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Oct 12, 2021
@johnniwinther
Copy link
Member

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

5 participants