Skip to content

[CP] Update analytics message and carry forward legacy opt-outs #52081

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jcollins-g opened this issue Apr 18, 2023 · 1 comment
Closed

[CP] Update analytics message and carry forward legacy opt-outs #52081

jcollins-g opened this issue Apr 18, 2023 · 1 comment
Assignees
Labels
cherry-pick-review Issue that need cherry pick triage to approve

Comments

@jcollins-g
Copy link
Contributor

Commit(s) to merge

a6ebd6f

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/295920

Issue Description

The PDD intended for analytics to actually substitute dart and flutter into the analytics message rather than using literally [dart|flutter]. Analytics does not import settings from the legacy analytics package.

What is the fix

String substitution, and a best effort attempt to carry forward the legacy analytics settings from dart or flutter into unified analytics.

Why cherry-pick

The string substitution is minor, but a lack of it could confuse users if they do not understand that [dart|flutter] in a command line is not to be taken literally. The honoring of opt-outs should be cherrypicked as it will be more convenient for users.

Risk

low

Issue link(s)

dart-lang/tools#74

Extra Info

No response

@jcollins-g jcollins-g added the cherry-pick-review Issue that need cherry pick triage to approve label Apr 18, 2023
@jcollins-g
Copy link
Contributor Author

Closing; somehow a duplicate issue was created.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Development

No branches or pull requests

6 participants