Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lint messages should contain the rule name #57205

Closed
zoechi opened this issue Mar 22, 2015 · 6 comments
Closed

Lint messages should contain the rule name #57205

zoechi opened this issue Mar 22, 2015 · 6 comments
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug

Comments

@zoechi
Copy link
Contributor

zoechi commented Mar 22, 2015

to make it easy to adapt the configuration (disable lints)

For example instead of just ... [lint] ... better ... [lint/camel_case_types] ...

@pq pq added the type-enhancement A request for a change that isn't a bug label Mar 22, 2015
@pq
Copy link
Member

pq commented Mar 22, 2015

I've been thinking about this. My worry is that the output will be too verbose. Maybe we should have a verbose flag to control this?

@pq
Copy link
Member

pq commented Mar 22, 2015

Paging @lukechurch as this is up his alley.

@zoechi
Copy link
Contributor Author

zoechi commented Mar 23, 2015

I think you can close this. The summary shows the rule names, I think this is enough. Seems I was just too tired to see it yesterday.
I just wondered why some are upper case and some lower case?

UNDEFINED_IDENTIFIER                                 12
UNDEFINED_METHOD                                      3
UNDEFINED_SETTER                                      1
URI_DOES_NOT_EXIST                                    8
constant_identifier_names                             6
empty_constructor_bodies                              1
library_prefixes                                     11
non_constant_identifier_names                         9

Readability is much better for lower case.

@pq
Copy link
Member

pq commented Mar 23, 2015

The UPPER_CASE error codes are from the analyzer. Those are static errors/warnings. I'm open to lower_case-ing them but would need to differentiate them some other way in the summary. Maybe a separate section (or column)? The summary could certainly be enhanced. Ideas welcome!

@zoechi
Copy link
Contributor Author

zoechi commented Mar 23, 2015

This was my suspicion.
I would use a prefix

analyzer/some_rule_name
linter/some_other_rule

or whatever will be used for the configuration comments/annotation to enable/disable them.
They should just be exactly the same everywhere where they occur.

@pq
Copy link
Member

pq commented Mar 24, 2015

Cool. Thanks! When we get further on ignore syntax we can revisit and pick it up there (#44) . In the meantime, I'll close this out.

@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 18, 2024
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants