Make SseConnection extend StreamChannelMixin<String> (dart-archive/sse#102)

Ilya Yanok · web-flow · commit 5c2e923f40c8 · 2024-02-09T09:22:57.000-08:00
I don't see any reason for the type argument to be nullable. Seems like a null safety migration artifact.
diff --git a/pkgs/sse/lib/src/server/sse_handler.dart b/pkgs/sse/lib/src/server/sse_handler.dart
@@ -28,7 +28,7 @@ class _SseMessage {
 }
 
 /// A bi-directional SSE connection between server and browser.
-class SseConnection extends StreamChannelMixin<String?> {
+class SseConnection extends StreamChannelMixin<String> {
   /// Incoming messages from the Browser client.
   final _incomingController = StreamController<String>();
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class _SseMessage {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`/// A bi-directional SSE connection between server and browser.`
`31`		`-class SseConnection extends StreamChannelMixin<String?> {`
	`31`	`+class SseConnection extends StreamChannelMixin<String> {`
`32`	`32`	`/// Incoming messages from the Browser client.`
`33`	`33`	`final _incomingController = StreamController<String>();`
`34`	`34`