Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Check and log a warning on data-streamed with download attribute #184

Open
dascritch opened this issue Sep 26, 2022 · 0 comments
Open

Check and log a warning on data-streamed with download attribute #184

dascritch opened this issue Sep 26, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dascritch
Copy link
Owner

dascritch commented Sep 26, 2022 •
edited
Loading

Even if we indicate in the documentation https://github.com/dascritch/cpu-audio/blob/master/INSTALL.md#indicate-a-prefered-downloadable-audio-resource to not use download attributes indicators when a media is indicated as streamed, I think it may be useful to indicate in a warn() this kind of misconfiguration.

IMHO, the best way to do it is to do an integrity check at CpuAudioElement class instantiation during the copyAttributesToMediaDataset() step.
@dascritch dascritch added enhancement New feature or request good first issue Good for newcomers labels Sep 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dascritch