Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build!: update rust to 1.83 #2393

Merged
merged 1 commit into from
Dec 17, 2024
Merged

build!: update rust to 1.83 #2393

merged 1 commit into from
Dec 17, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Dec 16, 2024

Issue being fixed or feature implemented

CI/CD fails because some dependency of cargo audit tool requires Rust 1.81.

What was done?

Updated Rust to 1.83 (most recent stable version).

How Has This Been Tested?

CI/CD

Breaking Changes

It is now required to use Rust 1.83+ to build the project.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • New Features

    • Added packages/wallet-utils-contract to the project workspace.
  • Bug Fixes

    • Updated Rust version requirements across documentation and configuration files to ensure compatibility.
  • Documentation

    • Revised the README to reflect the updated Rust version requirement from v1.80+ to v1.83+.
  • Chores

    • Updated the Rust toolchain version in the configuration files from 1.80 to 1.83.

@lklimek lklimek added this to the v1.8.0 milestone Dec 16, 2024
@lklimek lklimek self-assigned this Dec 16, 2024
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Walkthrough

This pull request focuses on updating the Rust version across multiple configuration files from version 1.80 to 1.83. The changes are consistent across Cargo.toml, README.md, and rust-toolchain.toml, indicating a systematic upgrade of the project's Rust toolchain. The workspace configuration in Cargo.toml has also been updated to include the packages/wallet-utils-contract package.

Changes

File Changes
Cargo.toml - Updated rust-version from "1.80" to "1.83"
- Added packages/wallet-utils-contract to workspace members
- Removed trailing whitespace in [patch.crates-io] section
README.md - Updated Rust version requirement from v1.80+ to v1.83+
rust-toolchain.toml - Changed toolchain channel from "1.80" to "1.83"

Possibly related PRs

Suggested labels

cleanup

Suggested reviewers

  • QuantumExplorer
  • shumkov

Poem

🐰 Rust version hopping, one point higher,
From 1.80 to 1.83, our code grows brighter!
Toolchains aligned, configs in sync,
A rabbit's upgrade with a playful wink!
Onward we code, with tooling so neat! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 494054a and aab92b1.

📒 Files selected for processing (3)
  • Cargo.toml (1 hunks)
  • README.md (1 hunks)
  • rust-toolchain.toml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • rust-toolchain.toml
🔇 Additional comments (3)
Cargo.toml (2)

31-31: Verify if wallet-utils-contract addition is intentional

The addition of "packages/wallet-utils-contract" to workspace members appears unrelated to the Rust version update PR. Please confirm if this change should be part of this PR.


35-35: Breaking Change: Rust version update to 1.83

The Rust version update is consistent with the PR objectives to support the cargo audit tool requirement.

Note: This is a breaking change that requires all developers to update their Rust toolchain to 1.83+.

✅ Verification successful

The search results show that all packages in the workspace use rust-version.workspace = true, which means they inherit the Rust version from the workspace root (Cargo.toml). Let me verify if there are any other Rust version constraints in the workspace root.


Rust version update to 1.83 is properly configured workspace-wide

The Rust version is correctly set to 1.83 in the workspace root's Cargo.toml, and all packages in the workspace inherit this version through rust-version.workspace = true. This configuration ensures consistent Rust toolchain requirements across all packages.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any rust version constraints in dependencies that might conflict
rg "rust-version|MSRV" -A 5 packages/*/Cargo.toml

Length of output: 9828


Script:

#!/bin/bash
# Check the workspace root Cargo.toml for rust-version and workspace settings
cat Cargo.toml

Length of output: 1327

README.md (1)

54-54: LGTM: Documentation updated for Rust version requirement

The README.md has been properly updated to reflect the new minimum Rust version requirement of v1.83+, maintaining consistency with the changes in Cargo.toml.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lklimek lklimek changed the title deps!: update rust to 1.83 build!: update rust to 1.83 Dec 16, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 82a6217 into v1.8-dev Dec 17, 2024
18 of 22 checks passed
@shumkov shumkov deleted the deps/update-rust-to-1.83 branch December 17, 2024 01:51
lklimek added a commit that referenced this pull request Dec 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants