Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Example in Readme not reproducible #75

Closed
ItSolGood opened this issue Mar 8, 2024 · 2 comments · Fixed by #77
Closed

Example in Readme not reproducible #75

ItSolGood opened this issue Mar 8, 2024 · 2 comments · Fixed by #77
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ItSolGood
Copy link
Contributor

The last example in README says:

ddt.to_deltalake(df, "s3://bucket_name/delta_path")

However, this does not seem compatible with the latest version of dask-deltatable. It should be instead:

ddt.to_deltalake("s3://bucket_name/delta_path", df)

or to keep the initial order of arguments:

ddt.to_deltalake(df=df, table_or_uri="s3://bucket_name/delta_path")

@jacobtomlinson
Copy link
Collaborator

You're right, I ran into this the other day too. Do you have any interest in opening a PR to fix this?

@jacobtomlinson jacobtomlinson added bug Something isn't working documentation Improvements or additions to documentation labels Mar 8, 2024
@ItSolGood
Copy link
Contributor Author

Happy too. First time that I make one though, so please bear with me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants