Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a pyproject.toml and some guidance around backwards compatibility #89

Open
rgommers opened this issue Nov 8, 2024 · 2 comments
Open
Labels
enhancement New feature or request Medium Priority

Comments

@rgommers
Copy link
Member

rgommers commented Nov 8, 2024

A project should have a pyproject.toml nowadays. I noticed it didn't after investigating a regression reported in conda-forge and seeing that the PR for 2.1.2 didn't pick up the numpy>=2.1 version constraint in conda-forge/array-api-strict-feedstock#12. I think it would (through Grayskull) if there would be a pyproject.toml to analyze.

Related: 2.1.2, as a bugfix version, should not contain a major breaking change like that. We don't need an extensive policy I think, but a few notes in the README about what can be expected for major, minor and bugfix versions would be useful.

@rgommers rgommers added the enhancement New feature or request label Nov 8, 2024
@asmeurer
Copy link
Member

asmeurer commented Nov 8, 2024

I think grayskull would work on setup.py metadata too.

Regarding the version number, I didn't expect this to be that breaking. But since it evidently is, we should just revert it. As I noted elsewhere, it was just a maintenance thing. We can continue to live with the extra technical debt in this repo for a little while longer.

@rgommers
Copy link
Member Author

rgommers commented Nov 8, 2024

Regarding the version number, I didn't expect this to be that breaking. But since it evidently is, we should just revert it. As I noted elsewhere, it was just a maintenance thing.

Sounds good, let's do that first. Could you perhaps tag a new version and roll it out, then the blast radius will be small/short?

I think grayskull would work on setup.py metadata too.

Yeah, I didn't realize it was disabled on the feedstock - will check that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request Medium Priority
Projects
None yet
Development

No branches or pull requests

2 participants