Skip to content

Commit a69025e

Browse files
committed
fix(pf4): clean up errors and functional issues noticed on pf demo page
1 parent 9bbb5f6 commit a69025e

File tree

6 files changed

+6
-11
lines changed

6 files changed

+6
-11
lines changed

packages/pf4-component-mapper/demo/index.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,6 @@ class App extends React.Component {
7777
}}
7878
componentMapper={{
7979
...componentMapper,
80-
'dual-list-select': {
81-
component: componentMapper['dual-list-select'],
82-
renderStatus: ({ selected, options }) => `selected ${selected} from ${options}`,
83-
},
8480
summary: Summary,
8581
}}
8682
FormTemplate={(props) => <FormTemplate {...props} showFormControls={this.state.additionalOptions.showFormControls} />}

packages/pf4-component-mapper/src/slider/slider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const Slider = (props) => {
1919
id={id || input.name}
2020
FormGroupProps={FormGroupProps}
2121
>
22-
<PF4Slider onChange={input.onChange} onValueChange={input.onChange} currentValue={input.value} inputValue={input.value} {...rest} />
22+
<PF4Slider onChange={input.onChange} value={input.value} inputValue={input.value} isDisabled={isDisabled || isReadOnly} {...rest} />
2323
</FormGroup>
2424
);
2525
};

packages/pf4-component-mapper/src/text-field/text-field.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@ const TextField = (props) => {
2626
{...rest}
2727
id={id || input.name}
2828
isRequired={isRequired}
29-
isReadOnly={isReadOnly}
3029
isDisabled={isDisabled}
31-
readOnly={isReadOnly}
30+
readOnlyVariant={isReadOnly ? 'default' : undefined}
3231
/>
3332
</FormGroup>
3433
);

packages/pf4-component-mapper/src/textarea/textarea.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const Textarea = (props) => {
2323
<Pf4TextArea
2424
{...showError(meta, validateOnMount)}
2525
isRequired={isRequired}
26-
disabled={isDisabled || isReadOnly}
26+
isDisabled={isDisabled || isReadOnly}
2727
{...input}
2828
id={id || input.name}
2929
{...rest}

packages/pf4-component-mapper/src/time-picker/time-picker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const TimePicker = (props) => {
1919
id={id || input.name}
2020
FormGroupProps={FormGroupProps}
2121
>
22-
<PF4TimePicker {...input} defaultTime={input.value} {...rest} id={id || input.name} isDisabled={isDisabled || isReadOnly} />
22+
<PF4TimePicker {...input} time={input.value ? input.value : undefined} {...rest} id={id || input.name} isDisabled={isDisabled || isReadOnly} />
2323
</FormGroup>
2424
);
2525
};

packages/pf4-component-mapper/src/wizard/wizard.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ const WizardInternal = ({
111111
title={title}
112112
description={description}
113113
onClose={formOptions.onCancel}
114-
hideClose={hideClose}
114+
isCloseHidden={hideClose}
115115
titleId={titleId}
116116
descriptionId={descriptionId}
117117
closeButtonAriaLabel={closeButtonAriaLabel}
@@ -120,7 +120,7 @@ const WizardInternal = ({
120120
<WizardToggle activeStepIndex={activeStepIndex} currentStep={currentStep} navSchema={navSchema} isOpen={state.openNav} dispatch={dispatch} />
121121
<div className="pf-v5-c-wizard__outer-wrap">
122122
<div className="pf-v5-c-wizard__inner-wrap">
123-
<WizardNav aria-label={navAriaLabel} isOpen={state.openNav}>
123+
<WizardNav aria-label={navAriaLabel} isExpanded={state.openNav}>
124124
<FormSpy subscription={{ values: true, valid: true, validating: true }}>
125125
{({ values, valid, validating }) => (
126126
<WizardNavigation

0 commit comments

Comments
 (0)