Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[CT-3781] fix: empty search results and constant loading #123

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[CT-3781] fix: empty search results and constant loading #123

merged 1 commit into from
Jul 11, 2022
+2 −1

Conversation

ben-brooker
Copy link
Contributor

@ben-brooker ben-brooker commented Jul 8, 2022 •
edited
Loading

TICKET

ISSUES: #110 #68

Changes made:

  • Fix the /search_functions api call. Without the packages parameter, the controller would throw an error for certain query parameters (see issues).
  • Fix the constant loading state when results are not available, I think its better to just say no results.

The below examples are related to the issues.

Before:
Screenshot 2022-07-08 at 12 01 16
Screenshot 2022-07-08 at 12 02 48
Screenshot 2022-07-08 at 12 01 29
Screenshot 2022-07-08 at 12 02 14

After:
Screenshot 2022-07-08 at 12 03 12
Screenshot 2022-07-08 at 12 04 00
Screenshot 2022-07-08 at 12 03 19
Screenshot 2022-07-08 at 12 04 00

@ben-brooker ben-brooker requested review from ztsorojev and Mim1991 July 8, 2022 11:08
@ben-brooker ben-brooker changed the title fix: empty search results and constant loading [CT-3781] fix: empty search results and constant loading Jul 11, 2022
@ben-brooker ben-brooker merged commit b0b316a into main Jul 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ztsorojev ztsorojev ztsorojev approved these changes

@Mim1991 Mim1991 Awaiting requested review from Mim1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-brooker @ztsorojev