Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit 3949a27

Browse files
authored
Merge pull request #718 from datafold/checksum-length-adjustment
14 → 12 checksum digits to support mssql
2 parents 8472467 + 1e1537c commit 3949a27

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

data_diff/databases/base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,8 +1140,7 @@ def is_autocommit(self) -> bool:
11401140
return False
11411141

11421142

1143-
# TODO FYI mssql md5_as_int currently requires this to be reduced
1144-
CHECKSUM_HEXDIGITS = 14 # Must be 15 or lower, otherwise SUM() overflows
1143+
CHECKSUM_HEXDIGITS = 12 # Must be 12 or lower, otherwise SUM() overflows
11451144
MD5_HEXDIGITS = 32
11461145

11471146
_CHECKSUM_BITSIZE = CHECKSUM_HEXDIGITS << 2

0 commit comments

Comments
 (0)