From d0e64c62353b474b21d5d3e84dae11ed49facde2 Mon Sep 17 00:00:00 2001 From: Valentin Khomutenko Date: Fri, 30 Jun 2023 19:06:12 +0200 Subject: [PATCH 1/2] fix KeyError exception for --json diffs --- data_diff/diff_tables.py | 4 +--- tests/test_api.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/data_diff/diff_tables.py b/data_diff/diff_tables.py index ffd80416..0c2d8805 100644 --- a/data_diff/diff_tables.py +++ b/data_diff/diff_tables.py @@ -177,9 +177,7 @@ def get_stats_dict(self, is_dbt: bool = False): "total": sum(diff_stats.diff_by_sign.values()), "stats": self.stats, } - if diff_stats.extra_column_diffs: - json_output["values"] = diff_stats.extra_column_diffs - + json_output["values"] = diff_stats.extra_column_diffs or {} return json_output diff --git a/tests/test_api.py b/tests/test_api.py index 88af2dbf..7c67163c 100644 --- a/tests/test_api.py +++ b/tests/test_api.py @@ -66,7 +66,7 @@ def test_api_get_stats_dict(self): "updated": 0, "unchanged": 4, "total": 1, - # "stats": {"rows_downloaded": 5}, + "values": {}, } t1 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_src_name) t2 = connect_to_table(TEST_MYSQL_CONN_STRING, self.table_dst_name) From b570f3f0ffd63eb43700d812dbabd67f89da3a05 Mon Sep 17 00:00:00 2001 From: Valentin Khomutenko Date: Fri, 30 Jun 2023 19:26:23 +0200 Subject: [PATCH 2/2] Update data_diff/diff_tables.py Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- data_diff/diff_tables.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data_diff/diff_tables.py b/data_diff/diff_tables.py index 0c2d8805..6d75e043 100644 --- a/data_diff/diff_tables.py +++ b/data_diff/diff_tables.py @@ -177,7 +177,7 @@ def get_stats_dict(self, is_dbt: bool = False): "total": sum(diff_stats.diff_by_sign.values()), "stats": self.stats, } - json_output["values"] = diff_stats.extra_column_diffs or {} + json_output["values"] = diff_stats.extra_column_diffs or {} return json_output