Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Retrieve regions from elasticsearch instead of catalogue #11

Closed
crijke opened this issue Jul 9, 2019 · 3 comments
Closed

Retrieve regions from elasticsearch instead of catalogue #11

crijke opened this issue Jul 9, 2019 · 3 comments
Assignees
@crijke
Labels
bug Something isn't working enhancement New feature or request

Comments

@crijke
Copy link
Collaborator

crijke commented Jul 9, 2019 •
edited
Loading

currently regions are fetched from the destatis catalog and not from the actual data. should we fetch them from the actual data instead?

also see CorrelAid/datenguideR#18
@crijke crijke changed the title __discuss: retrieve regions from elasticsearch instead of catalogue__ Retrieve regions from elasticsearch instead of catalogue__ Jul 9, 2019
@crijke crijke changed the title Retrieve regions from elasticsearch instead of catalogue__ Retrieve regions from elasticsearch instead of catalogue Jul 9, 2019
@crijke crijke added enhancement New feature or request question Further information is requested labels Jul 9, 2019
@dpprdan
Copy link

dpprdan commented Nov 11, 2019 •
edited
Loading

I think so: CorrelAid/datenguideR#18 (this seems potentially related at least).

@crijke crijke added bug Something isn't working and removed question Further information is requested labels Nov 12, 2019
@crijke crijke self-assigned this Nov 17, 2019
@dpprdan dpprdan mentioned this issue Nov 25, 2019
Open
@crijke
Copy link
Collaborator Author

crijke commented Nov 29, 2019

Until now datenguide-api has used a bundled list of regions, which got out of sync with the current statistics in the meantime.

With the next release of datenguide-api (v0.2.0) we will load regions from the automatically updated names.json schema from data.genesapi.org to ensure region data is always up to date.

@dpprdan
Copy link

dpprdan commented Dec 2, 2019

@crijke would it be okay/preferred to use names.json from data.genesapi.org in the R and Python packages re: CorrelAid/datenguideR#18 (as opposed to querying the datenguide-api for this)?

@crijke crijke closed this as completed Mar 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@crijke crijke

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crijke @dpprdan