Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cannot upload a file with slash in it #136

Open
kyegupov opened this issue Jan 26, 2023 · 4 comments
Open

cannot upload a file with slash in it #136

kyegupov opened this issue Jan 26, 2023 · 4 comments

Comments

@kyegupov
Copy link

crashes in Filesystem as S3Storage::complete_multipart_upload

@Nugine
Copy link
Contributor

Nugine commented Jan 26, 2023

Could you list the steps and reproduce the bug with s3s-fs? See #137.

@kyegupov
Copy link
Author

kyegupov commented Feb 1, 2023

s3s-fs cannot be built. When running just dev:
error: multiple versions for dependency `windows-sys`: 0.42.0, 0.45.0

@Nugine
Copy link
Contributor

Nugine commented Feb 2, 2023

It may be not the fault of s3s-fs since the CI is passing. It is probably caused by another outdated dependency in your project, which pulls old windows-sys crate version.

To find the cause, you can use cargo tree to list all your dependencies.

Edit:
Upstream issue confirmed. The duplicate dependency is caused by tokio. See tokio-rs/tokio#5386

@hUwUtao
Copy link

hUwUtao commented Oct 1, 2024

client might send the path that is urlencoded twice, thus the signature cannot be calculated correctly if not decoded once.
i did have a glance on the java implementation, might be it?
hUwUtao/s3-server/commit/173b5adbbb03ab6ce88f4dbeda4aeea6564cd8eb, tested on aws-cli, winscp

edit: on unix system, which use / as path seperator, it could not behave normally because this implementation does not support CommonPrefixes in src/storages/fs.rs

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants