fix code that computes module_name #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using methadone to create a new app with a name like “foo_bar_app”, the old code would compute module_name to be “Foobarapp” when it should be “FooBarApp”. This results in an error when trying to run the app generated by methadone. The app will crash with an error like: bin/foo_bar_app:38:in `<class:App>': uninitialized constant App::Foobarapp (NameError) from bin/foo_bar_app:7:in `<main>' This code will properly compute the module_name.
|
Nice catch - yeah the call to |
davetron5000
added a commit
that referenced
this pull request
Dec 26, 2012
fix code that computes module_name
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using methadone to create a new app with a name like
foo_bar_app, theold code would compute module_name to be
Foobarappwhen it should beFooBarApp. This results in an error when trying to run the appgenerated by methadone. The app will crash with an error like:
This code will properly compute the module_name.