improve CLI flags

[fetsorn]

I believe a bug in rtpmidid CLI confused me into looking for a networking issue.

I expected cli connect remote:142.42.215.21:5004 to reach for the server but instead it tried to connect to mDNS name "a:142.42.215.21:5004". I only noticed the difference after debugging with tcpdump and specifying cli connect remote 142.42.215.21 5004.

Correct if I'm wrong, but if that's what can happen, then it would be better to remove arguments from the connect command and only use explicit flags --ip --port --mdns --name.

[davidmoreno]

Hi, thanks for the report.

The format a:142.42.215:5004 is familiar to me.. I even think that maybe it was used in some moment in the past.

Was it you intuition to use it or do you remember where did you get the idea to use it like this? The format could be added and parsed as necessary, it should be quite easy.

The connect command can be used as well as rtpmidid-cli connect name=test hostname=192.168.1.100 port=5004. I'm not sure it's properly documented. I will try to do it.

I could easy add an optional -- at the beginning of the arguments.

BTW there is a rtpmidid-cli help that provides some documentation on available commands and arguments. As the rtpmidi-cli is mainly a RPC called into the JSON-RPC protocol, it just spits out the JSON, and arguments are just converted to JSON as well to be sent.. so it's a bit primitive.