Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add re-frame to cljs-oss/canary #478

Open
danielcompton opened this issue Jun 24, 2018 · 4 comments
Open

Add re-frame to cljs-oss/canary #478

danielcompton opened this issue Jun 24, 2018 · 4 comments
Assignees

Comments

@danielcompton
Copy link
Contributor

danielcompton commented Jun 24, 2018

@mfikes has already done the hard work of creating a canary config for https://github.com/cljs-oss/canary/tree/master. We should think about merging it in to this project, so we can run tests against the latest ClojureScript and detect any breaking changes well in advance.

@mike-thompson-day8 what do you think?

@mike-thompson-day8
Copy link
Contributor

mike-thompson-day8 commented Apr 5, 2020

I don't understand what's proposed in this issue yet but, for the record, I followed the provided link and it looks as though reagent and re-frame were recently deleted from oss-canary.

See cljs-oss/canary@16de8e6

@victorb
Copy link

victorb commented Apr 5, 2020

@mike-thompson-day8 it looks like re-frame had to be forked to support things like running the tests headlessly (switching chrome for phantomjs [although chrome can be run headless if you have chromedriver in the CI environment]), support for env vars to set the clojurescript version and config for running TravisCI tests.

Suggestion is to upstream those changes to this repository, so they will always be up-to-date, instead of having to maintain a separate, forked version, where any fixes to this repository would have to be merged, and potential merge conflicts resolved.

@mfikes
Copy link

mfikes commented Apr 6, 2020

I think something with PhantomJS was causing issues with the latest generated JavaScript and evidently moving to something more modern (Puppeteer?) can resolve the issues. I tried futzing with it and, not being well versed in web-dev technologies, didn't make any progress.

Ideally, yeah, if re-frame joined the Canary project, then re-frame team members would be notified for Canary build failures, be able to maintain things with respect to re-frame master, etc. (The chkup organization is a place where I am personally running Canary CI for other projects.)

@superstructor
Copy link
Contributor

The changes for this repository are done, now preparing an associated PR for cljs-oss/canary.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants