Skip to content

Commit fd622b0

Browse files
committed
fix: update prop types
1 parent 1b7d5ac commit fd622b0

File tree

6 files changed

+20
-32
lines changed

6 files changed

+20
-32
lines changed

packages/infinite-viewer/test/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ <h2 data-moveable>Infinite Viewer</h2>
385385
});
386386

387387
requestAnimationFrame(() => {
388-
const left = (viewer.getViewportWidth() - viewer.getContainerWidth() / viewer.getZoomX()) / 2
388+
const left = (viewer.getViewportWidth() - viewer.getContainerWidth() / viewer.getZoomX()) / 2;
389389
viewer.scrollTo(left, 0, {
390390
duration: 1000,
391391
});

packages/lit-infinite-viewer/src/LitInfiniteViewer.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { LitElement, html, customElement, property } from "lit-element";
22
import VanillaInfiniteViewer, {
3-
InfiniteViewerProperties,
3+
InfiniteViewerOptions,
44
EVENTS, PROPERTIES, InfiniteViewerMethods, METHODS, OPTIONS
55
} from "infinite-viewer";
66
import { Properties, withMethods, MethodInterface } from "framework-utils";
@@ -18,7 +18,7 @@ export class LitInfiniteViewer extends LitElement {
1818
})
1919
private infiniteViewer!: VanillaInfiniteViewer;
2020
public firstUpdated() {
21-
const options: Partial<InfiniteViewerProperties> = {};
21+
const options: Partial<InfiniteViewerOptions> = {};
2222

2323
OPTIONS.forEach(name => {
2424
if (typeof this[name] !== "undefined") {
@@ -74,7 +74,7 @@ export class LitInfiniteViewer extends LitElement {
7474
this.infiniteViewer.destroy();
7575
}
7676
}
77-
export interface LitInfiniteViewer extends InfiniteViewerProperties,
77+
export interface LitInfiniteViewer extends InfiniteViewerOptions,
7878
MethodInterface<InfiniteViewerMethods, VanillaInfiniteViewer, LitInfiniteViewer, {
7979
"click": "clickViewer",
8080
"scrollTo": "scrollToViewer",

packages/react-infinite-viewer/src/react-infinite-viewer/types.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { InfiniteViewerEvents, InfiniteViewerProperties } from "infinite-viewer";
1+
import { InfiniteViewerEvents, InfiniteViewerOptions } from "infinite-viewer";
22

33
export interface InfiniteViewerEventNames {
44
onScroll: "scroll";
@@ -12,6 +12,7 @@ export interface InfiniteViewerEventNames {
1212
export type InfiniteViewerEventProps = {
1313
[key in keyof InfiniteViewerEventNames]: (e: InfiniteViewerEvents[InfiniteViewerEventNames[key]]) => any;
1414
};
15-
export type InfiniteViewerProps = InfiniteViewerProperties & InfiniteViewerEventProps & {
15+
export type InfiniteViewerProps = InfiniteViewerOptions & InfiniteViewerEventProps & {
16+
className?: string;
1617
[key: string]: any;
1718
};
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,15 @@
1-
import VanillaInfiniteViewer, { InfiniteViewerMethods } from "infinite-viewer";
1+
import { SvelteComponentDev } from "svelte/internal";
2+
import VanillaInfiniteViewer, {
3+
InfiniteViewerOptions,
4+
InfiniteViewerMethods,
5+
} from "infinite-viewer";
26
import { MethodInterface } from "framework-utils";
37

4-
5-
interface ComponentOptions {
6-
target: HTMLElement;
7-
anchor?: HTMLElement | null;
8-
props?: {};
9-
hydrate?: boolean;
10-
intro?: boolean;
8+
export default class InfiniteViewerComponent<T={}> extends SvelteComponentDev {
9+
$$prop_def: InfiniteViewerOptions & T;
10+
getInstance(): VanillaInfiniteViewer;
1111
}
12-
13-
interface InfiniteViewerComponent extends MethodInterface<InfiniteViewerMethods, VanillaInfiniteViewer, InfiniteViewerComponent> {
14-
new(options: ComponentOptions): any;
15-
// client-side methods
16-
$set(props: {}): void;
17-
$on(event: string, callback: (event: CustomEvent) => void): void;
18-
$destroy(): void;
19-
// server-side methods
20-
render(props?: {}): {
21-
html: string;
22-
css: { code: string; map: string | null };
23-
head?: string;
24-
};
12+
export default interface InfiniteViewerComponent extends MethodInterface<InfiniteViewerMethods, VanillaInfiniteViewer, InfiniteViewerComponent> {
2513
}
2614

27-
export default InfiniteViewerComponent;
2815
export * from "infinite-viewer";

packages/vue-infinite-viewer/src/InfiniteViewer.vue.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { MethodInterface } from "framework-utils";
2-
import VanillaInfiniteViewer, { InfiniteViewerProperties, InfiniteViewerMethods } from "infinite-viewer";
2+
import VanillaInfiniteViewer, { InfiniteViewerOptions, InfiniteViewerMethods } from "infinite-viewer";
33

44
interface InfiniteViewerInterface
5-
extends InfiniteViewerProperties,
5+
extends InfiniteViewerOptions,
66
MethodInterface<
77
InfiniteViewerMethods,
88
VanillaInfiniteViewer,

packages/vue3-infinite-viewer/src/InfiniteViewer.vue.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { MethodInterface } from "framework-utils";
2-
import VanillaInfiniteViewer, { InfiniteViewerProperties, InfiniteViewerMethods } from "infinite-viewer";
2+
import VanillaInfiniteViewer, { InfiniteViewerOptions, InfiniteViewerMethods } from "infinite-viewer";
33

44
interface InfiniteViewerInterface
5-
extends InfiniteViewerProperties,
5+
extends InfiniteViewerOptions,
66
MethodInterface<
77
InfiniteViewerMethods,
88
VanillaInfiniteViewer,

0 commit comments

Comments
 (0)