Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Gitlab #34

Open
maddiemort opened this issue Jul 26, 2018 · 3 comments
Open

Support Gitlab #34

maddiemort opened this issue Jul 26, 2018 · 3 comments

Comments

@maddiemort
Copy link

Here's the log:

$ bundle exec danger --fail-on-errors=true
Passing the note body as a Hash is deprecated.  You should just pass the String.
[!] The exception involves the following plugins:
 -  danger-changelog
bundler: failed to load command: danger (/Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/bin/danger)
Danger::DSLError: 
[!] Invalid `Dangerfile` file: undefined method `github' for #<Danger::Dangerfile:0x00007fdb96ad97a0>
Did you mean?  git
               gitlab
 #  from Dangerfile:6
 #  -------------------------------------------
 #  
 >  changelog.check
 #  -------------------------------------------

  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/dangerfile.rb:69:in `method_missing'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/plugin_support/plugin.rb:23:in `method_missing'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-changelog-0.3.0/lib/changelog/plugin.rb:51:in `have_you_updated_changelog?'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-changelog-0.3.0/lib/changelog/plugin.rb:31:in `check'
  Dangerfile:6:in `block in parse'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/dangerfile.rb:200:in `eval'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/dangerfile.rb:200:in `block in parse'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/dangerfile.rb:196:in `instance_eval'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/dangerfile.rb:196:in `parse'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/dangerfile.rb:274:in `run'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/danger_core/executor.rb:28:in `run'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/lib/danger/commands/runner.rb:68:in `run'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/gems/danger-5.6.4/bin/danger:5:in `<top (required)>'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/bin/danger:23:in `load'
  /Users/xxxxx/builds/d9854cfb/0/xxxxx/xxxxx/vendor/bundle/ruby/2.3.0/bin/danger:23:in `<top (required)>'
ERROR: Job failed: exit status 1
@dblock
Copy link
Owner

dblock commented Jul 26, 2018

Never tried this on Gitlab. Would definitely take pull requests for gitlab support!

@dblock dblock changed the title Fails on GitLab when suggesting a changelog entry Support Gitlab Feb 2, 2020
@MateuszFilipekX
Copy link

Bumping the new feature

@dblock
Copy link
Owner

dblock commented Aug 31, 2022

Please contribute @MateuszFilipekX !

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants